Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: build/secondary/third_party/android_tools/BUILD.gn

Issue 1152203003: Add script to validate installed Android SDK packages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/install-android-sdks.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/android_tools/BUILD.gn
diff --git a/build/secondary/third_party/android_tools/BUILD.gn b/build/secondary/third_party/android_tools/BUILD.gn
index 8c75044b7a8a4c6414232739659b7fa0fbd25b6d..7d6d5ebe47c4f92b8dbbb02a4be86ec6ce987a0a 100644
--- a/build/secondary/third_party/android_tools/BUILD.gn
+++ b/build/secondary/third_party/android_tools/BUILD.gn
@@ -93,5 +93,28 @@ android_java_prebuilt("google_play_services_default_java") {
]
proguard_preprocess = true
proguard_config = "//third_party/android_tools/proguard.flags"
+
+ # TODO(dgn) deps should not complain about having a custom action here
+ # Currently, there is no guarantee that the data_deps actions will complete before the current one runs
+ data_deps = [ ":check_sdk_extras_version" ]
jar_path = "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/libs/google-play-services.jar"
}
+
+action("check_sdk_extras_version") {
+ script = "//build/check_sdk_extras_version.py"
+ args = [
+ "--package-id",
+ "extra-google-google_play_services",
+ "--package-location",
+ rebase_path("$android_sdk_root/extras/google/google_play_services"),
+ "--stamp",
+ rebase_path("$target_gen_dir/checked_sdk_extras_version.stamp"),
+ ]
+ inputs = [
+ "//build/android_sdk_extras.json",
+ "$android_sdk_root/extras/google/google_play_services/source.properties",
+ ]
+ outputs = [
+ "$target_gen_dir/checked_sdk_extras_version.stamp",
+ ]
+}
« no previous file with comments | « build/install-android-sdks.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698