build/install-android-sdks.sh - Issue 1152203003: Add script to validate installed Android SDK packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/install-android-sdks.sh

Issue 1152203003: Add script to validate installed Android SDK packages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/install-android-sdks.sh

diff --git a/build/install-android-sdks.sh b/build/install-android-sdks.sh

index 5c4edafec5b4a4ff85d148a4784209c55d698a22..1119b7d7fddeedeaf4af0ee3749c4da6c3a50213 100755

--- a/build/install-android-sdks.sh

+++ b/build/install-android-sdks.sh

@@ -12,14 +12,9 @@ echo 'checking for sdk packages install'

cwd=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )

# Get the SDK extras packages to install from the DEPS file 'sdkextras' hook.

packages="$(python ${cwd}/get_sdk_extras_packages.py)"

-for package in "${packages}"; do

- pkg_id=$(${cwd}/../third_party/android_tools/sdk/tools/android list sdk | \

- grep -i "$package," | \

- awk '/^[ ]*[0-9]*- / {gsub("-",""); print $1}')

- if [[ -n ${pkg_id} ]]; then

- ${cwd}/../third_party/android_tools/sdk/tools/android update sdk --no-ui \

- --filter ${pkg_id}

- fi

-done

+if [[ -n "${packages}" ]]; then

+ ${cwd}/../third_party/android_tools/sdk/tools/android update sdk --no-ui \

+ --filter ${packages}

+fi

echo "install-android-sdks.sh complete."

« no previous file with comments | « build/get_sdk_extras_packages.py ('k') | build/secondary/third_party/android_tools/BUILD.gn » ('j') | no next file with comments »