Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1152173003: Revert of Fix issue of localDescription and remoteDescription getter. (Closed)

Created:
5 years, 7 months ago by phoglund_chromium
Modified:
5 years, 7 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix issue of localDescription and remoteDescription getter. (patchset #8 id:140001 of https://codereview.chromium.org/1010393002/) Reason for revert: This patch breaks WebRTC browser tests (and, indeed, most WebRTC functionality, for instance apprtc.appspot.com calls). Original issue's description: > Fix issue of localDescription and remoteDescription getter. > > Current implementation returns a new RTCSessionDescription instance > when get localDescription and remoteDescription value. This causes error > of Javascript equality check. > > The CL fixes above issue. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195576 TBR=tommi@chromium.org,haraken@chromium.org,jl@opera.com,jochen@chromium.org,tommyw@chromium.org,yukishiino@chromium.org,bashi@chromium.org,changbin.shao@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -115 lines) Patch
M LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html View 2 chunks +2 lines, -8 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-localDescription-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html View 2 chunks +2 lines, -8 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 4 chunks +2 lines, -12 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 8 chunks +13 lines, -56 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCVoidRequestImpl.h View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/modules/mediastream/RTCVoidRequestImpl.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebRTCSessionDescription.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Created Revert of Fix issue of localDescription and remoteDescription getter.
5 years, 7 months ago (2015-05-22 11:12:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152173003/1
5 years, 7 months ago (2015-05-22 11:13:26 UTC) #2
haraken
LGTM That CL caused a couple of issues. It would be reasonable to fix them ...
5 years, 7 months ago (2015-05-22 11:13:47 UTC) #3
phoglund_chromium
On 2015/05/22 11:13:26, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 7 months ago (2015-05-22 11:14:24 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 11:14:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195778

Powered by Google App Engine
This is Rietveld 408576698