Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1152023004: dart2js: reuse stack trace on rethrow (Closed)

Created:
5 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, ahe
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: reuse stack trace on rethrow BUG= dartbug.com/15171 R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/1763aa3467d53c2129b440e126e01749ad51b677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +5 lines, -1 line 0 comments Download
A + tests/compiler/dart2js_extra/identical_trace_test.dart View 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
This is practically the same as Peter change in https://codereview.chromium.org/78343002/, I just moved the test ...
5 years, 6 months ago (2015-06-02 16:30:05 UTC) #2
Siggi Cherem (dart-lang)
Sigurd, could you take a look? it seems that Florian is going to be out ...
5 years, 6 months ago (2015-06-05 17:57:18 UTC) #4
sigurdm
LGTM !
5 years, 6 months ago (2015-06-08 06:33:44 UTC) #5
Siggi Cherem (dart-lang)
5 years, 6 months ago (2015-06-08 19:27:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1763aa3467d53c2129b440e126e01749ad51b677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698