Revert "Stop checking for duplicate basenames"

test/same-source-file-name/gyptest-shared.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
-Checks that gyp succeeds on shared_library targets which have several files with
+Checks that gyp fails on shared_library targets which have several files with
 the same basename.
 """
 
 import os
 
 import TestGyp
 
 test = TestGyp.TestGyp()
 
+# Fails by default for the compatibility with Visual C++ 2008 generator.
+# TODO: Update expected behavior when these legacy generators are deprecated.
+test.run_gyp('double-shared.gyp', chdir='src', status=1, stderr=None)
+
 if ((test.format == 'msvs') and
        (int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
-  test.run_gyp('double-shared.gyp',
+  test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
                chdir='src', status=0, stderr=None)
 else:
-  test.run_gyp('double-shared.gyp',
+  test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
                chdir='src')
   test.build('double-shared.gyp', test.ALL, chdir='src')
 
 test.pass_test()