Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: test/same-source-file-name/gyptest-shared.py

Issue 1151963003: Revert "Stop checking for duplicate basenames" (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/errors/gyptest-errors.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/same-source-file-name/gyptest-shared.py
diff --git a/test/same-source-file-name/gyptest-shared.py b/test/same-source-file-name/gyptest-shared.py
index 4cad63f6a179cc20f94d3a99efee6e0afd9e6a17..a57eb6159e492c7f8cc58481027eae82ad2b15c3 100755
--- a/test/same-source-file-name/gyptest-shared.py
+++ b/test/same-source-file-name/gyptest-shared.py
@@ -5,7 +5,7 @@
# found in the LICENSE file.
"""
-Checks that gyp succeeds on shared_library targets which have several files with
+Checks that gyp fails on shared_library targets which have several files with
the same basename.
"""
@@ -15,12 +15,16 @@ import TestGyp
test = TestGyp.TestGyp()
+# Fails by default for the compatibility with Visual C++ 2008 generator.
+# TODO: Update expected behavior when these legacy generators are deprecated.
+test.run_gyp('double-shared.gyp', chdir='src', status=1, stderr=None)
+
if ((test.format == 'msvs') and
(int(os.environ.get('GYP_MSVS_VERSION', 2010)) < 2010)):
- test.run_gyp('double-shared.gyp',
+ test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
chdir='src', status=0, stderr=None)
else:
- test.run_gyp('double-shared.gyp',
+ test.run_gyp('double-shared.gyp', '--no-duplicate-basename-check',
chdir='src')
test.build('double-shared.gyp', test.ALL, chdir='src')
« no previous file with comments | « test/errors/gyptest-errors.py ('k') | test/same-source-file-name/gyptest-static.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698