Revert "Stop checking for duplicate basenames"

Revert "Stop checking for duplicate basenames"

This reverts commit 540e4b1e665aa4a69c89906abf267904b571f87b.

Slightly updated to comment/target at libtool, rather than Mac make/MSVC08.

See https://codereview.chromium.org/670063006/#msg11
and https://code.google.com/p/gyp/issues/detail?id=384.

R=thakis@chromium.org
BUG=gyp:384
Committed: https://chromium.googlesource.com/external/gyp/+/c0cf1f22eb428073cf64e17c853f3c48303cb328

[scottmg, 2015-05-21 19:53:40]

(this breaks on memory/memory_pressure_monitor.cc win/memory_pressure_monitor.cc
at the moment in Chromium)

[Nico, 2015-05-21 23:50:07]

lgtm, thanks

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2496
pylib/gyp/input.py:2496: if target_dict.get('type', None) not in
('static_library', 'shared_library'):
Maybe shared_library can be removed here?

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2516
pylib/gyp/input.py:2516: target + error + 'Some build systems, e.g. MSVC08 and
Make generator '
Maybe this should say "libtool on mac" now?

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2867
pylib/gyp/input.py:2867: #               scalesystemdependent_arm_additions.c or
similar.
If the shared_library above goes away, this may or may not be needed any more

[yukawa, 2015-05-21 23:58:57]

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2517
pylib/gyp/input.py:2517: 'for Mac, cannot handle that. Use
--no-duplicate-basename-check to'
A white space between 'to' and 'disable'?

If this CL doesn't need to be a mechanical revert, it would be great if you can
put an extra space between 'to' and 'disable' in this sentence.
Sorry, it's I who wrote those lines.  Once I was glad that those lines were
removed but they have returned!

[scottmg, 2015-05-21 23:59:19]

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2496
pylib/gyp/input.py:2496: if target_dict.get('type', None) not in
('static_library', 'shared_library'):
On 2015/05/21 23:50:07, Nico wrote:
> Maybe shared_library can be removed here?

That seems pretty weird now that I look at it. I don't think it would have
worked for 'executable' either. Hm.

The only thing is that it seems a bit random to only disallow for
static_librarys. But I guess if it's not necessary, there's no point in
restricting it.

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2516
pylib/gyp/input.py:2516: target + error + 'Some build systems, e.g. MSVC08 and
Make generator '
On 2015/05/21 23:50:07, Nico wrote:
> Maybe this should say "libtool on mac" now?

Done.

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2867
pylib/gyp/input.py:2867: #               scalesystemdependent_arm_additions.c or
similar.
On 2015/05/21 23:50:07, Nico wrote:
> If the shared_library above goes away, this may or may not be needed any more

I'm feeling lucky. Done!

[scottmg, 2015-05-22 00:00:47]

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://codereview.chromium.org/1151963003/diff/1/pylib/gyp/input.py#newcode2517
pylib/gyp/input.py:2517: 'for Mac, cannot handle that. Use
--no-duplicate-basename-check to'
On 2015/05/21 23:58:57, yukawa wrote:
> A white space between 'to' and 'disable'?
> 
> If this CL doesn't need to be a mechanical revert, it would be great if you
can
> put an extra space between 'to' and 'disable' in this sentence.
> Sorry, it's I who wrote those lines.  Once I was glad that those lines were
> removed but they have returned!

I think I did this accidentally during reflowing.

Hopefully we can remove them again, someday!

[scottmg, 2015-05-22 00:11:19]

Committed patchset #2 (id:20001) manually as
c0cf1f22eb428073cf64e17c853f3c48303cb328.

[Nico, 2015-05-22 00:16:00]

On 2015/05/22 00:11:19, scottmg wrote:
> Committed patchset #2 (id:20001) manually as
> c0cf1f22eb428073cf64e17c853f3c48303cb328.

The -shared test might need updating? (Phone)

[scottmg, 2015-05-22 00:18:19]

On 2015/05/22 00:16:00, Nico wrote:
> On 2015/05/22 00:11:19, scottmg wrote:
> > Committed patchset #2 (id:20001) manually as
> > c0cf1f22eb428073cf64e17c853f3c48303cb328.
> 
> The -shared test might need updating? (Phone)

Doh, sorry thanks. Will fix.

[scottmg, 2015-05-22 00:26:14]

On 2015/05/22 00:18:19, scottmg wrote:
> On 2015/05/22 00:16:00, Nico wrote:
> > On 2015/05/22 00:11:19, scottmg wrote:
> > > Committed patchset #2 (id:20001) manually as
> > > c0cf1f22eb428073cf64e17c853f3c48303cb328.
> > 
> > The -shared test might need updating? (Phone)
> 
> Doh, sorry thanks. Will fix.

https://codereview.chromium.org/1153703002