Issue 1153703002: Update shared_library test after c0cf1f22eb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153703002: Update shared_library test after c0cf1f22eb (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

Update shared_library test after c0cf1f22eb Forgot to update test after removing shared_library case from target types that aren't allowed to have duplicate basenames. R=thakis@chromium.org BUG=gyp:384 Committed: https://chromium.googlesource.com/external/gyp/+/4dd5d3c614fb851b0ccda15bf66abec87b38ceb9

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -36 lines)			Patch
	A +	test/same-source-file-name/gyptest-pass-shared.py	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
	D	test/same-source-file-name/gyptest-shared.py	View		1 chunk	+0 lines, -31 lines	0 comments	Download

Total messages: 3 (0 generated)

scottmg

5 years, 7 months ago (2015-05-22 01:44:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4dd5d3c614fb851b0ccda15bf66abec87b38ceb9.