More unittests passing with new focus controller.

Get the rest of the ash_unittests to pass with the new FocusController (!)

Ash changes:

. Active RootWindow as tracked by the shell must only be updated when activation isn't being cleared.
. AshFocusRules' method that locates the next window to activate now searches forward and backward from the destroyed window's container. It used to only search forward.
. Some tests test for conditions that are no longer valid with the new focus controller, so we put some conditionals into the tests (PanelLayoutManagerTest and WindowManagerTest).
. ToplevelWindowEventFilterTest had an incomplete ash environment that wasn't getting all the right logic, so changed it to use full-ash.
. BubbleDelegateView needs to remove its observer to avoid a crash.

Core logic changes:

. A window must be focusable for it to be activatable. For some reason this test had eluded earlier incarnations.
. GetActivatableWindow() needs to be able to jump to a modal transient if one is present.
. GetFocusableWindow() needs to be able to hop to the next activatable window if the specified window isn't activatable.
. Prevent recursion in processing focus/activation changes.
. Prevent changing focus to the parent window when a child is focused.

R=sky@chromium.org
http://crbug.com/162100
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173011

[sky, 2012-12-13 21:38:05]

https://codereview.chromium.org/11519040/diff/21006/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/11519040/diff/21006/ash/shell.cc#newcode901
ash/shell.cc:901: if (gained_active)
Does this need to set active_root_window_ to NULL if gained_active == NULL?

https://codereview.chromium.org/11519040/diff/21006/ash/wm/ash_focus_rules.cc
File ash/wm/ash_focus_rules.cc (right):

https://codereview.chromium.org/11519040/diff/21006/ash/wm/ash_focus_rules.cc...
ash/wm/ash_focus_rules.cc:131: for (size_t i = starting_container_index - 1;
If starting_container_index == 0 this is going to overflow.

[Ben Goodger (Google), 2012-12-13 21:47:23]

We never want to set active_root_window_ to NULL.

https://codereview.chromium.org/11519040/diff/21006/ash/wm/ash_focus_rules.cc
File ash/wm/ash_focus_rules.cc (right):

https://codereview.chromium.org/11519040/diff/21006/ash/wm/ash_focus_rules.cc...
ash/wm/ash_focus_rules.cc:131: for (size_t i = starting_container_index - 1;
On 2012/12/13 21:38:06, sky wrote:
> If starting_container_index == 0 this is going to overflow.

Done.

[sky, 2012-12-13 22:00:25]

LGTM