More unittests passing with new focus controller.

ash/wm/toplevel_window_event_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/toplevel_window_event_handler.h"
 
 #include "ash/shell.h"
+#include "ash/shell_window_ids.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/workspace/snap_sizer.h"
 #include "ash/wm/workspace_controller.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/root_window.h"
@@ skipping 43 matching lines @@
   }
 
   int hittest_code_;
   gfx::Size min_size_;
 
   DISALLOW_COPY_AND_ASSIGN(TestWindowDelegate);
 };
 
 class ToplevelWindowEventHandlerTest : public AshTestBase {
  public:
-  ToplevelWindowEventHandlerTest() : parent_(NULL) {}
+  ToplevelWindowEventHandlerTest() {}
   virtual ~ToplevelWindowEventHandlerTest() {}
 
-  virtual void SetUp() OVERRIDE {
-    AshTestBase::SetUp();
-    parent_ = new aura::Window(NULL);
-    parent_->Init(ui::LAYER_NOT_DRAWN);
-    parent_->Show();
-    Shell::GetPrimaryRootWindow()->AddChild(parent_);
-    parent_->SetBounds(Shell::GetPrimaryRootWindow()->bounds());
-    handler_.reset(new ToplevelWindowEventHandler(parent_));
-    parent_->AddPreTargetHandler(handler_.get());
-  }
-
-  virtual void TearDown() OVERRIDE {
-    parent_->RemovePreTargetHandler(handler_.get());
-    handler_.reset();
-    parent_ = NULL;
-    AshTestBase::TearDown();
-  }
-
  protected:
   aura::Window* CreateWindow(int hittest_code) {
     TestWindowDelegate* d1 = new TestWindowDelegate(hittest_code);
     aura::Window* w1 = new aura::Window(d1);
     w1->set_id(1);
     w1->Init(ui::LAYER_TEXTURED);
-    parent_->AddChild(w1);
+    aura::Window* parent =
+      Shell::GetContainer(Shell::GetPrimaryRootWindow(),
+                          internal::kShellWindowId_AlwaysOnTopContainer);
+    parent->AddChild(w1);
     w1->SetBounds(gfx::Rect(0, 0, 100, 100));
     w1->Show();
     return w1;
   }
 
   void DragFromCenterBy(aura::Window* window, int dx, int dy) {
     aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(), window);
     generator.DragMouseBy(dx, dy);
   }
 
   void TouchDragFromCenterBy(aura::Window* window, int dx, int dy) {
     aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(), window);
     generator.PressMoveAndReleaseTouchBy(dx, dy);
   }
 
   scoped_ptr<ToplevelWindowEventHandler> handler_;
 
  private:
-  // Window |handler_| is installed on. Owned by RootWindow.
-  aura::Window* parent_;
-
   DISALLOW_COPY_AND_ASSIGN(ToplevelWindowEventHandlerTest);
 };
 
 }
 
 TEST_F(ToplevelWindowEventHandlerTest, Caption) {
   scoped_ptr<aura::Window> w1(CreateWindow(HTCAPTION));
   gfx::Size size = w1->bounds().size();
   DragFromCenterBy(w1.get(), 100, 100);
   // Position should have been offset by 100,100.
@@ skipping 376 matching lines @@
             GetRestoreBoundsInScreen(window.get())->ToString());
 }
 
 // Verifies pressing escape resets the bounds to the original bounds.
 #if defined(OS_MACOSX)
 #define MAYBE_EscapeReverts DISABLED_EscapeReverts
 #else
 #define MAYBE_EscapeReverts EscapeReverts
 #endif
 TEST_F(ToplevelWindowEventHandlerTest, MAYBE_EscapeReverts) {
-  aura::RootWindow* root = Shell::GetPrimaryRootWindow();
-  aura::client::ActivationClient* original_client =
-      aura::client::GetActivationClient(root);
-  aura::test::TestActivationClient activation_client(root);
   scoped_ptr<aura::Window> target(CreateWindow(HTBOTTOMRIGHT));
-  target->Focus();
   aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
                                        target.get());
   generator.PressLeftButton();
   generator.MoveMouseBy(10, 11);
 
   // Execute any scheduled draws so that pending mouse events are processed.
   RunAllPendingInMessageLoop();
 
   EXPECT_EQ("0,0 110x111", target->bounds().ToString());
   generator.PressKey(ui::VKEY_ESCAPE, 0);
   generator.ReleaseKey(ui::VKEY_ESCAPE, 0);
   EXPECT_EQ("0,0 100x100", target->bounds().ToString());
-  aura::client::SetActivationClient(root, original_client);
 }
 
 // Verifies window minimization/maximization completes drag.
 TEST_F(ToplevelWindowEventHandlerTest, MinimizeMaximizeCompletes) {
   // Once window is minimized, window dragging completes.
   {
     scoped_ptr<aura::Window> target(CreateWindow(HTCAPTION));
     target->Focus();
     aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
                                          target.get());
@@ skipping 27 matching lines @@
 
     generator.PressLeftButton();
     generator.MoveMouseBy(10, 11);
     RunAllPendingInMessageLoop();
     EXPECT_EQ("10,11 100x100", target->bounds().ToString());
   }
 }
 
 }  // namespace test
 }  // namespace ash