Issue 11519012: Ensure that the Inspect Element operation when performed on Windows 8 Metro ASH opens a docked dev …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11519012: Ensure that the Inspect Element operation when performed on Windows 8 Metro ASH opens a docked dev … (Closed)

Created:
8 years ago by ananta

Modified:
8 years ago

Reviewers:
sky, sky, pfeldman

CC:
chromium-reviews, vsevik, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ensure that the Inspect Element operation when performed on Windows 8 Metro ASH opens a docked dev tools window. Currently if this operation is performed on Windows 8 ASH we end up opening the Dev tools window in desktop mode which is incorrect. This happens because we attempt to find the inspected WebContents instance in the desktop browser list. Fix is to find the inspected webcontents in the desktop and the ASH browser lists as they can both be active concurrently for Windows 8. BUG=151718 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172360

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	chrome/browser/debugger/devtools_window.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	chrome/browser/debugger/devtools_window.cc	View	1 2	2 chunks	+28 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 11519012: Ensure that the Inspect Element operation when performed on Windows 8 Metro ASH opens a docked dev … (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages