Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/debugger/devtools_window.h

Issue 11519012: Ensure that the Inspect Element operation when performed on Windows 8 Metro ASH opens a docked dev … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 class Browser; 22 class Browser;
23 class BrowserWindow; 23 class BrowserWindow;
24 class PrefService; 24 class PrefService;
25 class Profile; 25 class Profile;
26 26
27 namespace base { 27 namespace base {
28 class Value; 28 class Value;
29 } 29 }
30 30
31 namespace chrome {
32 class BrowserListImpl;
33 }
34
31 namespace content { 35 namespace content {
32 class DevToolsAgentHost; 36 class DevToolsAgentHost;
33 class DevToolsClientHost; 37 class DevToolsClientHost;
34 struct FileChooserParams; 38 struct FileChooserParams;
35 class RenderViewHost; 39 class RenderViewHost;
36 class WebContents; 40 class WebContents;
37 } 41 }
38 42
39 namespace IPC { 43 namespace IPC {
40 class Message; 44 class Message;
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 content::RenderViewHost* inspected_rvh, 116 content::RenderViewHost* inspected_rvh,
113 DevToolsDockSide dock_side, 117 DevToolsDockSide dock_side,
114 bool shared_worker_frontend); 118 bool shared_worker_frontend);
115 DevToolsWindow(content::WebContents* web_contents, 119 DevToolsWindow(content::WebContents* web_contents,
116 Profile* profile, 120 Profile* profile,
117 content::RenderViewHost* inspected_rvh, 121 content::RenderViewHost* inspected_rvh,
118 DevToolsDockSide dock_side); 122 DevToolsDockSide dock_side);
119 123
120 void CreateDevToolsBrowser(); 124 void CreateDevToolsBrowser();
121 bool FindInspectedBrowserAndTabIndex(Browser**, int* tab); 125 bool FindInspectedBrowserAndTabIndex(Browser**, int* tab);
126 bool FindInspectedBrowserAndTabIndexFromBrowserList(
127 chrome::BrowserListImpl* browser_list,
128 Browser** browser,
129 int* tab);
122 BrowserWindow* GetInspectedBrowserWindow(); 130 BrowserWindow* GetInspectedBrowserWindow();
123 bool IsInspectedBrowserPopupOrPanel(); 131 bool IsInspectedBrowserPopupOrPanel();
124 void UpdateFrontendDockSide(); 132 void UpdateFrontendDockSide();
125 133
126 // Overridden from content::NotificationObserver. 134 // Overridden from content::NotificationObserver.
127 virtual void Observe(int type, 135 virtual void Observe(int type,
128 const content::NotificationSource& source, 136 const content::NotificationSource& source,
129 const content::NotificationDetails& details) OVERRIDE; 137 const content::NotificationDetails& details) OVERRIDE;
130 138
131 void ScheduleAction(DevToolsToggleAction action); 139 void ScheduleAction(DevToolsToggleAction action);
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 DevToolsToggleAction action_on_load_; 206 DevToolsToggleAction action_on_load_;
199 content::NotificationRegistrar registrar_; 207 content::NotificationRegistrar registrar_;
200 content::DevToolsClientHost* frontend_host_; 208 content::DevToolsClientHost* frontend_host_;
201 scoped_ptr<DevToolsFileHelper> file_helper_; 209 scoped_ptr<DevToolsFileHelper> file_helper_;
202 int width_; 210 int width_;
203 int height_; 211 int height_;
204 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 212 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
205 }; 213 };
206 214
207 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 215 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698