Issue 11519009: Merge 136785

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11519009: Merge 136785 (Closed)

Created:
8 years ago by adamk

Modified:
8 years ago

Reviewers:
adamk

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

More Reviews

Description

Merge 136785 > Add runtime enable for web intents. > https://bugs.webkit.org/show_bug.cgi?id=103669 > > Patch by Greg Billock <gbillock@google.com>; on 2012-12-05 > Reviewed by Adam Barth. > > Source/WebCore: > > Make web intents Javascript API enabled by a runtime setting. > > * Modules/intents/DOMWindowIntents.idl: > * Modules/intents/NavigatorIntents.idl: > * bindings/generic/RuntimeEnabledFeatures.cpp: > (WebCore): > * bindings/generic/RuntimeEnabledFeatures.h: > (RuntimeEnabledFeatures): > (WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled): > (WebCore::RuntimeEnabledFeatures::webkitIntentEnabled): > (WebCore::RuntimeEnabledFeatures::webKitIntentEnabled): > (WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled): > > Source/WebKit/chromium: > > Propagate runtime setting to enable/disable web intents Javascript API. > > * public/WebRuntimeFeatures.h: > (WebRuntimeFeatures): > * src/WebRuntimeFeatures.cpp: > (WebKit::WebRuntimeFeatures::enableWebIntents): > (WebKit): > (WebKit::WebRuntimeFeatures::isWebIntentsEnabled): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137212

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -5 lines)			Patch
M	Source/WebCore/Modules/intents/DOMWindowIntents.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/Modules/intents/NavigatorIntents.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/public/WebRuntimeFeatures.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

On 2012/12/10 22:59:20, adamk wrote:

lgtm

Expand Messages | Collapse Messages