Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151793003: Adds (somewhat crappy) controls to example game (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds a spaceship and (somewhat crappy) controls to the example game. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6b3ebfc71760f4b5c7b7404b0e64bc372b6eefc7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -22 lines) Patch
M sky/examples/game/lib/game.dart View 1 chunk +2 lines, -1 line 0 comments Download
A sky/examples/game/lib/game_box.dart View 1 chunk +71 lines, -0 lines 0 comments Download
M sky/examples/game/lib/game_world.dart View 3 chunks +108 lines, -20 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/game/lib/sprites.dart View 1 chunk +1 line, -0 lines 1 comment Download
M sky/examples/game/main.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
viktorl
5 years, 6 months ago (2015-06-04 23:45:30 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1151793003/diff/1/sky/examples/game/lib/sprites.dart File sky/examples/game/lib/sprites.dart (right): https://codereview.chromium.org/1151793003/diff/1/sky/examples/game/lib/sprites.dart#newcode8 sky/examples/game/lib/sprites.dart:8: //import 'package:sky/framework/rendering/node.dart'; You can just delete this. This ...
5 years, 6 months ago (2015-06-04 23:49:42 UTC) #4
viktorl
5 years, 6 months ago (2015-06-05 00:14:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6b3ebfc71760f4b5c7b7404b0e64bc372b6eefc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698