Enable Java assertions in locally run Java binaries.

build/android/gyp/create_java_binary_script.py

Index: build/android/gyp/create_java_binary_script.py
diff --git a/build/android/gyp/create_java_binary_script.py b/build/android/gyp/create_java_binary_script.py
index d632728ac7a79662e193904b096f58fe163d0bcc..5de43f2d4a45d7f8b2b73394803926a5b5edd0cc 100755
--- a/build/android/gyp/create_java_binary_script.py
+++ b/build/android/gyp/create_java_binary_script.py
@@ -36,6 +36,7 @@ if os.getcwd() != self_dir:
 java_args = [
   "java",
   "-classpath", ":".join(classpath),
+  "-enableassertions",

[cjhopman, 2015/06/17 21:50:15]

So this enables assertions for all java binaries. Is that what we want? If so,
the description should reflect that.

Alternatively, we could make this script accept a list of args to pass to the
java command and update the build targets that we want to actually pass such
args.

I'm okay with either approach. I think that the second one (allowing build
targets to inject args) is something that we will eventually want, but I'll
leave it up to you what to do for this change.

[Bernhard Bauer, 2015/06/18 16:37:25]

Hm, I don't really see an advantage in having assertions off, except maybe for
existing tests that would fail, but that doesn't seem to be the case at the
moment. I'm thinking that if we turn assertions on now for all tests, we'll have
a much easier time than if we turn them on later. So I would prefer to go with
that option; I swear I'm not just saying that because it's less work for me ;-)
I updated the CL description accordingly.

[cjhopman, 2015/06/19 22:39:07]

Well, this isn't just for tests. I'd agree that for all tests we would want
assertions enabled. For non-test binaries, I don't know that that's the case,
but I'm not really opposed to doing it and changing it later if we decide we
don't want assertions for something.

I would drop the second line from the description though, this change should be
made assuming that it doesn't apply only to tests.

   \"{main_class}\"] + sys.argv[1:]
 os.execvp("java", java_args)
 """