Enable Java assertions in locally run Java binaries.

build/android/gyp/create_java_binary_script.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Creates a simple script to run a java "binary".
 
 This creates a script that sets up the java command line for running a java
 jar. This includes correctly setting the classpath and the main class.
@@ skipping 18 matching lines @@
 import sys
 
 self_dir = os.path.dirname(__file__)
 classpath = [{classpath}]
 if os.getcwd() != self_dir:
   offset = os.path.relpath(self_dir, os.getcwd())
   classpath = [os.path.join(offset, p) for p in classpath]
 java_args = [
   "java",
   "-classpath", ":".join(classpath),
+  "-enableassertions",

[cjhopman, 2015/06/17 21:50:15]

So this enables assertions for all java binaries. Is that what we want? If so,
the description should reflect that.

Alternatively, we could make this script accept a list of args to pass to the
java command and update the build targets that we want to actually pass such
args.

I'm okay with either approach. I think that the second one (allowing build
targets to inject args) is something that we will eventually want, but I'll
leave it up to you what to do for this change.

[Bernhard Bauer, 2015/06/18 16:37:25]

Hm, I don't really see an advantage in having assertions off, except maybe for
existing tests that would fail, but that doesn't seem to be the case at the
moment. I'm thinking that if we turn assertions on now for all tests, we'll have
a much easier time than if we turn them on later. So I would prefer to go with
that option; I swear I'm not just saying that because it's less work for me ;-)
I updated the CL description accordingly.

[cjhopman, 2015/06/19 22:39:07]

Well, this isn't just for tests. I'd agree that for all tests we would want
assertions enabled. For non-test binaries, I don't know that that's the case,
but I'm not really opposed to doing it and changing it later if we decide we
don't want assertions for something.

I would drop the second line from the description though, this change should be
made assuming that it doesn't apply only to tests.

   \"{main_class}\"] + sys.argv[1:]
 os.execvp("java", java_args)
 """
 
 def main(argv):
   argv = build_utils.ExpandFileArgs(argv)
   parser = optparse.OptionParser()
   build_utils.AddDepfileOption(parser)
   parser.add_option('--output', help='Output path for executable script.')
   parser.add_option('--jar-path', help='Path to the main jar.')
@@ skipping 18 matching lines @@
   os.chmod(options.output, 0750)
 
   if options.depfile:
     build_utils.WriteDepfile(
         options.depfile,
         build_utils.GetPythonDependencies())
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))