dbus/object_proxy.cc - Issue 115173002: dbus: Always return "not yet handled" for signals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/object_proxy.cc

Issue 115173002: dbus: Always return "not yet handled" for signals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus/object_proxy.cc

diff --git a/dbus/object_proxy.cc b/dbus/object_proxy.cc

index d506392cf05417282800a1fc10880203efecd976..d296a996c88e2c8d3e5e6622f4de5be4248da20d 100644

--- a/dbus/object_proxy.cc

+++ b/dbus/object_proxy.cc

@@ -523,7 +523,9 @@ DBusHandlerResult ObjectProxy::HandleMessage(

RunMethod(start_time, iter->second, released_signal);

}

- return DBUS_HANDLER_RESULT_HANDLED;

+ // We don't return DBUS_HANDLER_RESULT_HANDLED for signals because other

+ // objects may be interested in them.

Daniel Erat 2013/12/13 18:11:37 nit: maybe explicitly mention NameOwnerChanged her

hashimoto 2013/12/17 04:01:34 Added a comment.

+ return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;

}

void ObjectProxy::RunMethod(base::TimeTicks start_time,

« no previous file with comments | « no previous file | no next file » | no next file with comments »