dbus: Always return "not yet handled" for signals

dbus/object_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/bus.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 505 matching lines @@
                                                      iter->second,
                                                      released_signal));
   } else {
     const base::TimeTicks start_time = base::TimeTicks::Now();
     // If the D-Bus thread is not used, just call the callback on the
     // current thread. Transfer the ownership of |signal| to RunMethod().
     Signal* released_signal = signal.release();
     RunMethod(start_time, iter->second, released_signal);
   }
 
-  return DBUS_HANDLER_RESULT_HANDLED;
+  // We don't return DBUS_HANDLER_RESULT_HANDLED for signals because other
+  // objects may be interested in them.

[Daniel Erat, 2013/12/13 18:11:37]

nit: maybe explicitly mention NameOwnerChanged here? (i left a comment about
this on the bug, too)

[hashimoto, 2013/12/17 04:01:34]

Added a comment.

+  return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
 }
 
 void ObjectProxy::RunMethod(base::TimeTicks start_time,
                             std::vector<SignalCallback> signal_callbacks,
                             Signal* signal) {
   bus_->AssertOnOriginThread();
 
   for (std::vector<SignalCallback>::iterator iter = signal_callbacks.begin();
        iter != signal_callbacks.end(); ++iter)
     iter->Run(signal);
@@ skipping 155 matching lines @@
     bool service_is_available) {
   bus_->AssertOnOriginThread();
 
   std::vector<WaitForServiceToBeAvailableCallback> callbacks;
   callbacks.swap(wait_for_service_to_be_available_callbacks_);
   for (size_t i = 0; i < callbacks.size(); ++i)
     callbacks[i].Run(service_is_available);
 }
 
 }  // namespace dbus