Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 115173002: dbus: Always return "not yet handled" for signals (Closed)

Created:
7 years ago by hashimoto
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Daniel Erat
Visibility:
Public.

Description

dbus: Always return "not yet handled" for signals BUG=327172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241222

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M dbus/object_proxy.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
7 years ago (2013-12-13 12:25:37 UTC) #1
Daniel Erat
lgtm Thanks! https://codereview.chromium.org/115173002/diff/1/dbus/object_proxy.cc File dbus/object_proxy.cc (right): https://codereview.chromium.org/115173002/diff/1/dbus/object_proxy.cc#newcode527 dbus/object_proxy.cc:527: // objects may be interested in them. ...
7 years ago (2013-12-13 18:11:37 UTC) #2
satorux1
lgtm. please address derat's comment
7 years ago (2013-12-17 02:22:16 UTC) #3
hashimoto
https://codereview.chromium.org/115173002/diff/1/dbus/object_proxy.cc File dbus/object_proxy.cc (right): https://codereview.chromium.org/115173002/diff/1/dbus/object_proxy.cc#newcode527 dbus/object_proxy.cc:527: // objects may be interested in them. On 2013/12/13 ...
7 years ago (2013-12-17 04:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/115173002/20001
7 years ago (2013-12-17 04:08:12 UTC) #5
commit-bot: I haz the power
Change committed as 241222
7 years ago (2013-12-17 08:41:58 UTC) #6
Amokbambi
6 years, 11 months ago (2013-12-31 17:11:18 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698