Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151693005: Remove uniform view matrix from GrGLPrimitiveProcessor base class (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove uniform view matrix from GrGLPrimitiveProcessor base class BUG=skia: Committed: https://skia.googlesource.com/skia/+/5559ca2a18687ef16b2fc92d8fcacbc1c3e93d54

Patch Set 1 #

Total comments: 2

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -85 lines) Patch
M src/gpu/GrDefaultGeoProcFactory.cpp View 4 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 4 chunks +12 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +34 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 13 chunks +43 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 1 chunk +24 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 3 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, a straightforward review
5 years, 7 months ago (2015-05-21 15:01:52 UTC) #2
robertphillips
lgtm + questions https://codereview.chromium.org/1151693005/diff/1/src/gpu/GrDefaultGeoProcFactory.cpp File src/gpu/GrDefaultGeoProcFactory.cpp (right): https://codereview.chromium.org/1151693005/diff/1/src/gpu/GrDefaultGeoProcFactory.cpp#newcode133 src/gpu/GrDefaultGeoProcFactory.cpp:133: if (!dgp.viewMatrix().isIdentity() && !fViewMatrix.cheapEqualTo(dgp.viewMatrix())) { You ...
5 years, 7 months ago (2015-05-21 18:07:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151693005/20001
5 years, 7 months ago (2015-05-21 19:38:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 22:50:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5559ca2a18687ef16b2fc92d8fcacbc1c3e93d54

Powered by Google App Engine
This is Rietveld 408576698