Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1151633004: Revert of Implement timers by posting delayed tasks (Closed)

Created:
5 years, 7 months ago by Julien - ping for review
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-wtf_chromium.org, dglazkov+blink, dstockwell, Eric Willigers, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin, kinuko+worker_chromium.org, Mike Lawther (Google), Mikhail, rjwright, shans, Steve Block, Timothy Loh, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Implement timers by posting delayed tasks (patchset #18 id:340001 of https://codereview.chromium.org/1134523002/) Reason for revert: The patch made some content_browsertests fail on Linux: DomSerializerTests.SerializeHTMLDOMWithDocType DomSerializerTests.SerializeHTMLDOMWithEmptyHead DomSerializerTests.SerializeHTMLDOMWithEntitiesInText DomSerializerTests.SerializeHTMLDOMWithMultipleMetaCharsetInOriginalDoc DomSerializerTests.SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc DomSerializerTests.SerializeHTMLDOMWithoutDocType RenderFrameHostManagerTest.DisownOpener Original issue's description: > Implement timers by posting delayed tasks > > This patch refactors TimerBase to post tasks delayed tasks and > deletes the now-obsolete timer heap and shared timer mechanism. > > ATTN Sheriffs: If there are weird layout test flakes all of a > sudden, this patch may be the cause since the interleaving of > timers with other posted tasks will change. > > Original patch by Alex Clarke <alexclarke@chromium.org>;. > > BUG=463143, 416362, 480522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195706 TBR=jochen@chromium.org,alexclarke@chromium.org,erikcorry@chromium.org,kinuko@chromium.org,rmcilroy@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143, 416362, 480522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1061 lines, -301 lines) Patch
M Source/core/Init.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/fetch/CachingCorrectnessTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/fetch/ResourceTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 5 chunks +102 lines, -0 lines 0 comments Download
A Source/platform/PlatformThreadData.h View 1 chunk +59 lines, -0 lines 0 comments Download
A Source/platform/PlatformThreadData.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
A Source/platform/SharedTimer.h View 1 chunk +75 lines, -0 lines 0 comments Download
A Source/platform/SharedTimer.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
A Source/platform/ThreadTimers.h View 1 chunk +67 lines, -0 lines 0 comments Download
A Source/platform/ThreadTimers.cpp View 1 chunk +153 lines, -0 lines 0 comments Download
M Source/platform/Timer.h View 4 chunks +26 lines, -9 lines 0 comments Download
M Source/platform/Timer.cpp View 6 chunks +327 lines, -39 lines 0 comments Download
M Source/platform/TimerTest.cpp View 4 chunks +110 lines, -162 lines 0 comments Download
M Source/platform/blink_platform.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableAreaTest.cpp View 3 chunks +3 lines, -68 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julien - ping for review
Created Revert of Implement timers by posting delayed tasks
5 years, 7 months ago (2015-05-21 19:59:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151633004/1
5 years, 7 months ago (2015-05-21 20:00:25 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 20:01:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195725

Powered by Google App Engine
This is Rietveld 408576698