Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 115163002: Disable two DomSerializerTests in preperation of page serializer merge (Closed)

Created:
7 years ago by Tiger
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable two DomSerializerTests in preperation of page serializer merge BUG=328354 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240671

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comments and bug links #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/renderer/dom_serializer_browsertest.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tiger
7 years ago (2013-12-13 12:16:24 UTC) #1
jochen (gone - plz use gerrit)
please reference a bug in the cl description and in the comment. If none exist, ...
7 years ago (2013-12-13 12:19:42 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-13 12:19:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiger@opera.com/115163002/20001
7 years ago (2013-12-13 12:37:12 UTC) #4
commit-bot: I haz the power
Change committed as 240671
7 years ago (2013-12-13 16:28:20 UTC) #5
Tiger
A revert of this CL has been created in https://codereview.chromium.org/117413002/ by tiger@opera.com. The reason for ...
7 years ago (2013-12-17 16:32:52 UTC) #6
Tiger
7 years ago (2013-12-17 21:40:13 UTC) #7
Message was sent while issue was closed.
On 2013/12/17 16:32:52, Tiger wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/117413002/ by mailto:tiger@opera.com.
> 
> The reason for reverting is: Invalid. Doesn't disable the tests..

Instead of reverting I will fix this in
https://codereview.chromium.org/106023004/ instead.

Powered by Google App Engine
This is Rietveld 408576698