Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1151573004: Use a deque in ResourcePool instead of a list. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO), piman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a deque in ResourcePool instead of a list. Find in a list is terribly slow. Deques are much faster. R=reveman BUG=487387 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a0b6f0b592500b9010dafa3def52ee3fd1a72d54 Cr-Commit-Position: refs/heads/master@{#332102}

Patch Set 1 #

Patch Set 2 : deque: . #

Patch Set 3 : deque: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/resources/resource_pool.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
danakj
5 years, 6 months ago (2015-05-29 23:27:38 UTC) #1
danakj
citation: http://blog.davidecoppola.com/2014/05/cpp-benchmarks-vector-vs-list-vs-deque/
5 years, 6 months ago (2015-05-29 23:29:58 UTC) #2
reveman
lgtm
5 years, 6 months ago (2015-05-29 23:44:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151573004/20001
5 years, 6 months ago (2015-05-29 23:55:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/29784) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-05-29 23:59:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151573004/40001
5 years, 6 months ago (2015-05-30 00:09:06 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-30 02:27:29 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 02:28:15 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0b6f0b592500b9010dafa3def52ee3fd1a72d54
Cr-Commit-Position: refs/heads/master@{#332102}

Powered by Google App Engine
This is Rietveld 408576698