Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1151503005: Correct gfx dependency for cast_receiver_app. (Closed)

Created:
5 years, 7 months ago by bungeman-chromium
Modified:
5 years, 7 months ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cmake6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct gfx dependency for cast_receiver_app. The cast_receiver_app target was moved with https://codereview.chromium.org/248083005 r265690 84b92fa8262514ba3097a55b550147837a08e906 . However, when this was done, the gfx.gyp:gfx_geometry target was added to 'sources' instead of 'dependencies'. Committed: https://crrev.com/87e6e16627fee7a3f1e5076a8d20dcdffdc93255 Cr-Commit-Position: refs/heads/master@{#331586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/cast/cast_testing.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
bungeman-chromium
5 years, 7 months ago (2015-05-26 22:27:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151503005/1
5 years, 7 months ago (2015-05-26 22:27:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-26 23:27:33 UTC) #6
bungeman-chromium
5 years, 7 months ago (2015-05-27 13:52:00 UTC) #8
miu
lgtm
5 years, 7 months ago (2015-05-27 16:55:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151503005/1
5 years, 7 months ago (2015-05-27 16:56:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 17:00:03 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 17:01:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87e6e16627fee7a3f1e5076a8d20dcdffdc93255
Cr-Commit-Position: refs/heads/master@{#331586}

Powered by Google App Engine
This is Rietveld 408576698