Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 248083005: Reland: [Cast] Consolidate plethora of GYP files into cast.gyp and cast_testing.gypi. (Closed)

Created:
6 years, 8 months ago by miu
Modified:
6 years, 8 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

Reland: [Cast] Consolidate plethora of GYP files into cast.gyp and cast_testing.gypi. Reland of r265481 (https://codereview.chromium.org/245893005/) with the following fixes: 1. Re-introduce 'include_tests%' conditional. 2. Conditionally include all Cast utility app targets based on a new GYP variable: include_cast_utility_apps 3. Fixed compile errors exposed by landing r265481 on the tree. Testing: 1. This change was tested by building on Linux: `build/gyp_chromium && ninja -C out/Debug All` 2. Confirmed absence of 'include_cast_utility_apps=1' in chromium.gyp_env will disable the Cast utility targets. 3. Ran utility apps to confirm the fixes. R=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265690

Patch Set 1 #

Patch Set 2 : Fixes to problems exposed by r265481. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -835 lines) Patch
M chrome/chrome_browser.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D media/cast/audio_receiver/audio_receiver.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D media/cast/audio_sender/audio_sender.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
M media/cast/cast.gyp View 1 1 chunk +216 lines, -137 lines 0 comments Download
D media/cast/cast_config.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D media/cast/cast_receiver.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D media/cast/cast_sender.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
A media/cast/cast_testing.gypi View 1 1 chunk +231 lines, -0 lines 0 comments Download
D media/cast/congestion_control/congestion_control.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D media/cast/framer/framer.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D media/cast/logging/logging.gyp View 1 chunk +0 lines, -92 lines 0 comments Download
D media/cast/rtcp/rtcp.gyp View 1 chunk +0 lines, -56 lines 0 comments Download
D media/cast/rtp_receiver/rtp_parser/rtp_parser.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D media/cast/rtp_receiver/rtp_receiver.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
M media/cast/test/utility/generate_barcode_video.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/test/utility/generate_timecode_audio.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
D media/cast/test/utility/utility.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
D media/cast/transport/cast_transport.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D media/cast/transport/utility/utility.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D media/cast/video_receiver/video_receiver.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
D media/cast/video_sender/codecs/vp8/vp8_encoder.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D media/cast/video_sender/video_sender.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_lib.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/mutate/mutate.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
miu
hclam: PTAL at the diff between PS1 and PS2. Patch set 1 is what I ...
6 years, 8 months ago (2014-04-23 04:41:53 UTC) #1
Alpha Left Google
LGTM.
6 years, 8 months ago (2014-04-23 18:10:17 UTC) #2
miu
6 years, 8 months ago (2014-04-23 18:30:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r265690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698