[sync] Componentize sync: Part 2: Add SYNC_EXPORTs to files in src/sync/

sync/syncable/directory.h

Index: sync/syncable/directory.h
diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h
index 42475305c2952ee7608194050e7e0c5e301e8cb7..4a8ea9b3022d3c9d01517b978881277aafb0c335 100644
--- a/sync/syncable/directory.h
+++ b/sync/syncable/directory.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -11,6 +11,7 @@
 
 #include "base/file_util.h"
 #include "base/gtest_prod_util.h"
+#include "sync/base/sync_export.h"
 #include "sync/internal_api/public/util/report_unrecoverable_error_function.h"
 #include "sync/internal_api/public/util/weak_handle.h"
 #include "sync/syncable/dir_open_result.h"
@@ -248,7 +249,7 @@ class Directory {
 
   // The download progress is an opaque token provided by the sync server
   // to indicate the continuation state of the next GetUpdates operation.
-  void GetDownloadProgress(
+  SYNC_EXPORT void GetDownloadProgress(
       ModelType type,
       sync_pb::DataTypeProgressMarker* value_out) const;
   void GetDownloadProgressAsString(
@@ -285,7 +286,7 @@ class Directory {
   void SetNotificationState(const std::string& notification_state);
 
   // Unique to each account / client pair.
-  std::string cache_guid() const;
+  SYNC_EXPORT std::string cache_guid() const;

[akalin, 2012/12/11 00:02:52]

yeah, i guess I'm not sure if annotating member functions is a good thing.  So
something outside of sync can have a Cryptographer*, but if it calls the wrong
function it leads to a linker error?  Hmm.  I haven't seen this in other uses of
*_EXPORT but maybe it's uncommon.  Perhaps consult with one of the export gurus
(rsleevi?) about this?

[Raghu Simha, 2012/12/11 01:27:51]

I did a bunch of grepping of the source code for other FOO_EXPORT usage, and
you're right -- I couldn't find precedent for method-only exports. I've gone and
fixed all instances in this CL.

 
   // Returns a pointer to our Nigori node handler.
   NigoriHandler* GetNigoriHandler();