[sync] Componentize sync: Part 2: Add SYNC_EXPORTs to files in src/sync/

sync/syncable/directory.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_SYNCABLE_DIRECTORY_H_
 #define SYNC_SYNCABLE_DIRECTORY_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/gtest_prod_util.h"
+#include "sync/base/sync_export.h"
 #include "sync/internal_api/public/util/report_unrecoverable_error_function.h"
 #include "sync/internal_api/public/util/weak_handle.h"
 #include "sync/syncable/dir_open_result.h"
 #include "sync/syncable/entry_kernel.h"
 #include "sync/syncable/metahandle_set.h"
 #include "sync/syncable/scoped_kernel_lock.h"
 
 namespace syncer {
 
 class Cryptographer;
@@ skipping 217 matching lines @@
 
   int64 NextMetahandle();
   // Always returns a negative id.  Positive client ids are generated
   // by the server only.
   Id NextId();
 
   bool good() const { return NULL != kernel_; }
 
   // The download progress is an opaque token provided by the sync server
   // to indicate the continuation state of the next GetUpdates operation.
-  void GetDownloadProgress(
+  SYNC_EXPORT void GetDownloadProgress(
       ModelType type,
       sync_pb::DataTypeProgressMarker* value_out) const;
   void GetDownloadProgressAsString(
       ModelType type,
       std::string* value_out) const;
   size_t GetEntriesCount() const;
   void SetDownloadProgress(
       ModelType type,
       const sync_pb::DataTypeProgressMarker& value);
 
@@ skipping 16 matching lines @@
 
   // (Account) Bag of chip is an opaque state used by the server to track the
   // client.
   std::string bag_of_chips() const;
   void set_bag_of_chips(const std::string& bag_of_chips);
 
   std::string GetNotificationState() const;
   void SetNotificationState(const std::string& notification_state);
 
   // Unique to each account / client pair.
-  std::string cache_guid() const;
+  SYNC_EXPORT std::string cache_guid() const;

[akalin, 2012/12/11 00:02:52]

yeah, i guess I'm not sure if annotating member functions is a good thing.  So
something outside of sync can have a Cryptographer*, but if it calls the wrong
function it leads to a linker error?  Hmm.  I haven't seen this in other uses of
*_EXPORT but maybe it's uncommon.  Perhaps consult with one of the export gurus
(rsleevi?) about this?

[Raghu Simha, 2012/12/11 01:27:51]

I did a bunch of grepping of the source code for other FOO_EXPORT usage, and
you're right -- I couldn't find precedent for method-only exports. I've gone and
fixed all instances in this CL.

 
   // Returns a pointer to our Nigori node handler.
   NigoriHandler* GetNigoriHandler();
 
   // Returns a pointer to our cryptographer. Does not transfer ownership.
   // Not thread safe, so should only be accessed while holding a transaction.
   Cryptographer* GetCryptographer(const BaseTransaction* trans);
 
   // Returns true if the directory had encountered an unrecoverable error.
   // Note: Any function in |Directory| that can be called without holding a
@@ skipping 336 matching lines @@
   NigoriHandler* const nigori_handler_;
   Cryptographer* const cryptographer_;
 
   InvariantCheckLevel invariant_check_level_;
 };
 
 }  // namespace syncable
 }  // namespace syncer
 
 #endif // SYNC_SYNCABLE_DIRECTORY_H_