src/arm64/assembler-arm64-inl.h - Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/assembler-arm64-inl.h

Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/assembler-arm64-inl.h

diff --git a/src/arm64/assembler-arm64-inl.h b/src/arm64/assembler-arm64-inl.h

index 373f15dc4b1967bd91f7e960903d6dbe4593766d..1432c288d8d8d0bed2815c03222ebe22236b811f 100644

--- a/src/arm64/assembler-arm64-inl.h

+++ b/src/arm64/assembler-arm64-inl.h

@@ -867,8 +867,8 @@ bool RelocInfo::IsPatchedReturnSequence() {

// See arm64/debug-arm64.cc BreakLocation::SetDebugBreakAtReturn().

Instruction* i1 = reinterpret_cast<Instruction*>(pc_);

Instruction* i2 = i1->following();

- return i1->IsLdrLiteralX() && (i1->Rt() == ip0.code()) &&

- i2->IsBranchAndLinkToRegister() && (i2->Rn() == ip0.code());

+ return i1->IsLdrLiteralX() && (i1->Rt() == kIp0Code) &&

+ i2->IsBranchAndLinkToRegister() && (i2->Rn() == kIp0Code);

}

« no previous file with comments | « src/arm64/assembler-arm64.cc ('k') | src/arm64/constants-arm64.h » ('j') | no next file with comments »