Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: src/arm64/assembler-arm64-inl.h

Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/assembler-arm64.cc ('k') | src/arm64/constants-arm64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_ 5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_
6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_ 6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_
7 7
8 #include "src/arm64/assembler-arm64.h" 8 #include "src/arm64/assembler-arm64.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
860 } 860 }
861 861
862 862
863 bool RelocInfo::IsPatchedReturnSequence() { 863 bool RelocInfo::IsPatchedReturnSequence() {
864 // The sequence must be: 864 // The sequence must be:
865 // ldr ip0, [pc, #offset] 865 // ldr ip0, [pc, #offset]
866 // blr ip0 866 // blr ip0
867 // See arm64/debug-arm64.cc BreakLocation::SetDebugBreakAtReturn(). 867 // See arm64/debug-arm64.cc BreakLocation::SetDebugBreakAtReturn().
868 Instruction* i1 = reinterpret_cast<Instruction*>(pc_); 868 Instruction* i1 = reinterpret_cast<Instruction*>(pc_);
869 Instruction* i2 = i1->following(); 869 Instruction* i2 = i1->following();
870 return i1->IsLdrLiteralX() && (i1->Rt() == ip0.code()) && 870 return i1->IsLdrLiteralX() && (i1->Rt() == kIp0Code) &&
871 i2->IsBranchAndLinkToRegister() && (i2->Rn() == ip0.code()); 871 i2->IsBranchAndLinkToRegister() && (i2->Rn() == kIp0Code);
872 } 872 }
873 873
874 874
875 bool RelocInfo::IsPatchedDebugBreakSlotSequence() { 875 bool RelocInfo::IsPatchedDebugBreakSlotSequence() {
876 Instruction* current_instr = reinterpret_cast<Instruction*>(pc_); 876 Instruction* current_instr = reinterpret_cast<Instruction*>(pc_);
877 return !current_instr->IsNop(Assembler::DEBUG_BREAK_NOP); 877 return !current_instr->IsNop(Assembler::DEBUG_BREAK_NOP);
878 } 878 }
879 879
880 880
881 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { 881 void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 1294
1295 1295
1296 void Assembler::ClearRecordedAstId() { 1296 void Assembler::ClearRecordedAstId() {
1297 recorded_ast_id_ = TypeFeedbackId::None(); 1297 recorded_ast_id_ = TypeFeedbackId::None();
1298 } 1298 }
1299 1299
1300 1300
1301 } } // namespace v8::internal 1301 } } // namespace v8::internal
1302 1302
1303 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_ 1303 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_
OLDNEW
« no previous file with comments | « src/arm64/assembler-arm64.cc ('k') | src/arm64/constants-arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698