Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412). (Closed)

Created:
5 years, 7 months ago by jbramley

Modified:
5 years, 7 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412). These trigger warnings on cross-builds under GCC. BUG= Committed: https://crrev.com/8af3c3a1034c945b1a24ee4935f63e89e07b9e05 Cr-Commit-Position: refs/heads/master@{#28509}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	src/arm64/assembler-arm64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm64/assembler-arm64-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm64/constants-arm64.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm64/instructions-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151463002/1

5 years, 7 months ago (2015-05-20 12:14:32 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 12:37:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8af3c3a1034c945b1a24ee4935f63e89e07b9e05
Cr-Commit-Position: refs/heads/master@{#28509}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages