Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1151393006: An accessibility tree update with two roots should be rejected. (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

An accessibility tree update with two roots should be rejected. If an AXTreeUpdate had two root nodes, the second one would cause the first one to be deleted, but that could leave dangling pointers in |pending_nodes|. Fix this by first ensuring that |pending_nodes| is always cleaned up when nodse are deleted, but also by specifically returning an error if we encounter two root nodes since that should never happen. BUG=479743 Committed: https://crrev.com/e3b7faf115bcd4fec56b1658e60abe077d77f379 Cr-Commit-Position: refs/heads/master@{#332212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -19 lines) Patch
M ui/accessibility/ax_tree.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 9 chunks +31 lines, -16 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
3 years, 7 months ago (2015-05-29 06:43:00 UTC) #2
aboxhall
lgtm
3 years, 7 months ago (2015-06-01 16:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151393006/1
3 years, 7 months ago (2015-06-01 16:48:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 7 months ago (2015-06-01 17:56:45 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2015-06-01 17:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3b7faf115bcd4fec56b1658e60abe077d77f379
Cr-Commit-Position: refs/heads/master@{#332212}

Powered by Google App Engine
This is Rietveld 408576698