Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1151383009: Use R0/R1 instead of R4/R5 for eh_return on ARM (Closed)

Created:
5 years, 6 months ago by Derek Schuff
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-gcc.git@pnacl
Target Ref:
refs/heads/pnacl
Visibility:
Public.

Description

Use R0/R1 instead of R4/R5 for eh_return on ARM This should unblock removal of _Unwind_PNaClSetResult{0,1} entirely. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4171 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-gcc.git;a=commit;h=a2fe95dbfd10df1b8d4e375e4668dc1e98e237e7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gcc/unwind-pnacl.h View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Derek Schuff
5 years, 6 months ago (2015-06-03 00:28:28 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/1151383009/diff/1/gcc/unwind-pnacl.h File gcc/unwind-pnacl.h (left): https://codereview.chromium.org/1151383009/diff/1/gcc/unwind-pnacl.h#oldcode100 gcc/unwind-pnacl.h:100: #else I wonder if mips is going to ...
5 years, 6 months ago (2015-06-03 17:21:05 UTC) #3
Derek Schuff
https://codereview.chromium.org/1151383009/diff/1/gcc/unwind-pnacl.h File gcc/unwind-pnacl.h (left): https://codereview.chromium.org/1151383009/diff/1/gcc/unwind-pnacl.h#oldcode100 gcc/unwind-pnacl.h:100: #else On 2015/06/03 17:21:04, jvoung wrote: > I wonder ...
5 years, 6 months ago (2015-06-03 20:51:11 UTC) #4
Derek Schuff
5 years, 6 months ago (2015-06-03 20:51:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2fe95dbfd10df1b8d4e375e4668dc1e98e237e7 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698