Update Confirmation UI for saved password change

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 10debdbfbf8089b689c2d9bb800f01c72c7cec36..5ff40845bb9e0f096f26d4011600200efd73e583 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -80,6 +80,11 @@ class ManagePasswordsUIController
   // and WILL be in MANAGE_STATE after this method executes.
   virtual void SavePassword();
 
+  // Called from the model when the user chooses to update a password; passes
+  // the action off to the FormManager. The controller MUST be in a pending

[vabr (Chromium), 2015/06/03 16:33:26]

nit: Pass off means "happen or be concluded in a specified, usually satisfactory
way". Maybe you meant just "pass"?

[dvadym, 2015/06/19 15:27:29]

I've copied it from lines 78-80. Those lines were written by mkwst, I'll ask him
on Monday.

[vabr (Chromium), 2015/06/19 18:03:16]

So, what did you hear back? :)

[dvadym, 2015/07/23 09:45:43]

I've removed "off" in SavePassword and UpdatePassword description

+  // state, and WILL be in MANAGE_STATE after this method executes.
+  virtual void UpdatePassword(const autofill::PasswordForm& password_form);
+
   // Called from the model when the user chooses a credential.
   // The controller MUST be in a pending credentials state.
   virtual void ChooseCredential(
@@ -151,6 +156,8 @@ class ManagePasswordsUIController
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
+  virtual void UpdatePasswordInternal(

[vasilii, 2015/06/03 18:32:02]

The fact that this function exists means that you wanted to add a unit test but
forgot :-) Thus, please add a unit test for both  ManagePasswordsUIController
and ManagePasswordsBubbleModel.

[dvadym, 2015/06/19 15:27:29]

Sure, I've just forgotten to indicate in test of CL that tests are not ready

+      const autofill::PasswordForm& password_form);
   virtual void NeverSavePasswordInternal();
 
   // Called when a PasswordForm is autofilled, when a new PasswordForm is