Update Confirmation UI for saved password change

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
@@ skipping 62 matching lines @@
 
   // PasswordStore::Observer implementation.
   void OnLoginsChanged(
       const password_manager::PasswordStoreChangeList& changes) override;
 
   // Called from the model when the user chooses to save a password; passes the
   // action off to the FormManager. The controller MUST be in a pending state,
   // and WILL be in MANAGE_STATE after this method executes.
   virtual void SavePassword();
 
+  // Called from the model when the user chooses to update a password; passes
+  // the action off to the FormManager. The controller MUST be in a pending

[vabr (Chromium), 2015/06/03 16:33:26]

nit: Pass off means "happen or be concluded in a specified, usually satisfactory
way". Maybe you meant just "pass"?

[dvadym, 2015/06/19 15:27:29]

I've copied it from lines 78-80. Those lines were written by mkwst, I'll ask him
on Monday.

[vabr (Chromium), 2015/06/19 18:03:16]

So, what did you hear back? :)

[dvadym, 2015/07/23 09:45:43]

I've removed "off" in SavePassword and UpdatePassword description

+  // state, and WILL be in MANAGE_STATE after this method executes.
+  virtual void UpdatePassword(const autofill::PasswordForm& password_form);
+
   // Called from the model when the user chooses a credential.
   // The controller MUST be in a pending credentials state.
   virtual void ChooseCredential(
       const autofill::PasswordForm& form,
       password_manager::CredentialType credential_type);
 
   // Called from the model when the user chooses to never save passwords; passes
   // the action off to the FormManager. The controller MUST be in a pending
   // state, and WILL be in BLACKLIST_STATE after this method executes.
   virtual void NeverSavePassword();
@@ skipping 51 matching lines @@
     return passwords_data_.federated_credentials_forms();
   }
 
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
+  virtual void UpdatePasswordInternal(

[vasilii, 2015/06/03 18:32:02]

The fact that this function exists means that you wanted to add a unit test but
forgot :-) Thus, please add a unit test for both  ManagePasswordsUIController
and ManagePasswordsBubbleModel.

[dvadym, 2015/06/19 15:27:29]

Sure, I've just forgotten to indicate in test of CL that tests are not ready

+      const autofill::PasswordForm& password_form);
   virtual void NeverSavePasswordInternal();
 
   // Called when a PasswordForm is autofilled, when a new PasswordForm is
   // submitted, or when a navigation occurs to update the visibility of the
   // manage passwords icon and bubble.
   virtual void UpdateBubbleAndIconVisibility();
 
   // Returns the time elapsed since |timer_| was initialized,
   // or base::TimeDelta::Max() if |timer_| was not initialized.
   virtual base::TimeDelta Elapsed() const;
@@ skipping 31 matching lines @@
   scoped_ptr<base::ElapsedTimer> timer_;
 
   // Contains true if the bubble is to be popped up in the next call to
   // UpdateBubbleAndIconVisibility().
   bool should_pop_up_bubble_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_