Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2856)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index af537be63d2e730cf5bcdfe686090f0b2a2c9a90..4042f728ef015dd25d41def0fa800dcfd3857cba 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -247,6 +247,16 @@ void ManagePasswordsBubbleModel::OnSaveClicked() {
state_ = password_manager::ui::MANAGE_STATE;
}
+void ManagePasswordsBubbleModel::OnUpdateClicked(
+ const autofill::PasswordForm& password_form) {
+ dismissal_reason_ = metrics_util::CLICKED_UPDATE;
+ RecordExperimentStatistics(web_contents(), dismissal_reason_);
+ ManagePasswordsUIController* manage_passwords_ui_controller =
+ ManagePasswordsUIController::FromWebContents(web_contents());
+ manage_passwords_ui_controller->UpdatePassword(password_form);
+ state_ = password_manager::ui::MANAGE_STATE;
+}
+
void ManagePasswordsBubbleModel::OnDoneClicked() {
dismissal_reason_ = metrics_util::CLICKED_DONE;
}
@@ -335,6 +345,10 @@ int ManagePasswordsBubbleModel::PasswordFieldWidth() {
void ManagePasswordsBubbleModel::UpdatePendingStateTitle() {
title_brand_link_range_ = gfx::Range();
+ int title_message_id =
+ pending_password_.is_password_change_form_without_username
+ ? IDS_UPDATE_PASSWORD
+ : IDS_SAVE_PASSWORD;
if (never_save_passwords_) {
title_ = l10n_util::GetStringUTF16(
IDS_MANAGE_PASSWORDS_BLACKLIST_CONFIRMATION_TITLE);
@@ -343,11 +357,15 @@ void ManagePasswordsBubbleModel::UpdatePendingStateTitle() {
base::string16 brand_link =
l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SMART_LOCK);
size_t offset = 0;
- title_ = l10n_util::GetStringFUTF16(IDS_SAVE_PASSWORD, brand_link, &offset);
+ title_ = l10n_util::GetStringFUTF16(title_message_id, brand_link, &offset);
title_brand_link_range_ = gfx::Range(offset, offset + brand_link.length());
} else {
base::string16 brand_link =
l10n_util::GetStringUTF16(IDS_SAVE_PASSWORD_TITLE_BRAND);
- title_ = l10n_util::GetStringFUTF16(IDS_SAVE_PASSWORD, brand_link);
+ title_ = l10n_util::GetStringFUTF16(title_message_id, brand_link);
}
+ save_button_text_ = l10n_util::GetStringUTF16(
vasilii 2015/06/03 18:32:01 This should go to the constructor.
dvadym 2015/06/19 15:27:29 Done.
+ pending_password_.is_password_change_form_without_username
+ ? IDS_PASSWORD_MANAGER_UPDATE_BUTTON
+ : IDS_PASSWORD_MANAGER_SAVE_BUTTON);
}

Powered by Google App Engine
This is Rietveld 408576698