components/password_manager/core/browser/stub_password_manager_client.cc - Issue 1151373006: Update Confirmation UI for saved password change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewers' comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager.cc ('K') | « components/password_manager/core/browser/stub_password_manager_client.h ('k') | components/password_manager/core/common/password_manager_switches.h » ('j') | components/password_manager/core/common/password_manager_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.cc

diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc

index c2e01684a51fd59719c100088e1718485d537884..289f03c818096f80b799e7f4784677e7e387b18b 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.cc

+++ b/components/password_manager/core/browser/stub_password_manager_client.cc

@@ -30,9 +30,10 @@ bool StubPasswordManagerClient::ShouldFilterAutofillResult(

return false;

}

-bool StubPasswordManagerClient::PromptUserToSavePassword(

+bool StubPasswordManagerClient::PromptUserToSaveOrUpdatePassword(

scoped_ptr<PasswordFormManager> form_to_save,

- password_manager::CredentialSourceType type) {

+ password_manager::CredentialSourceType type,

+ bool update_password) {

return false;

}