Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewers' comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 49d8af61029a148beffc92ad5568d0c067b0b046..092290ca724beddbc3a44a7f2d6268ac88b2379f 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -682,9 +682,11 @@ void PasswordManager::AskUserOrSavePassword() {
empty_password);
if (logger)
logger->LogMessage(Logger::STRING_DECISION_ASK);
- if (client_->PromptUserToSavePassword(
+ if (client_->PromptUserToSaveOrUpdatePassword(
provisional_save_manager_.Pass(),
- CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER)) {
+ CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER,
+ provisional_save_manager_->observed_form()
+ .IsPossibleChangePasswordFormWithoutUsername())) {
vasilii 2015/07/27 15:44:49 What happens for the forms with username?
dvadym 2015/07/30 11:22:44 They will be processed the same way as now, namely
if (logger)
logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT);
}

Powered by Google App Engine
This is Rietveld 408576698