Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewers' comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index cc072113cf7d2b5ca08c5c7d6c1f1c96b8b6af01..8dd11b6d7b69803aa8b583a8fee6c81c9ca2f13b 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -76,13 +76,14 @@ class PasswordManagerClient {
// this signal to report statistics. Default implementation is a noop.
virtual void AutofillResultsComputed();
- // Informs the embedder of a password form that can be saved if the user
- // allows it. The embedder is not required to prompt the user if it decides
- // that this form doesn't need to be saved.
- // Returns true if the prompt was indeed displayed.
- virtual bool PromptUserToSavePassword(
+ // Informs the embedder of a password form that can be saved or updated in
+ // password store if the user allows it. The embedder is not required to
+ // prompt the user if it decides that this form doesn't need to be saved or
+ // updated. Returns true if the prompt was indeed displayed.
+ virtual bool PromptUserToSaveOrUpdatePassword(
scoped_ptr<PasswordFormManager> form_to_save,
- CredentialSourceType type) = 0;
+ CredentialSourceType type,
+ bool update_password) = 0;
// Informs the embedder of a password forms that the user should choose from.
// Returns true if the prompt is indeed displayed. If the prompt is not
@@ -171,6 +172,9 @@ class PasswordManagerClient {
// Returns the main frame URL.
virtual const GURL& GetMainFrameURL() const;
+ // Returns true if the UI for confirmation of update password is enabled.
+ virtual bool IsUpdatePasswordUIEnabled() const;
+
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698