Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test compilation error, updated comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 82d3bb6c36d461cff6ada49c9baab83535fdf42d..05a69007c37108d44d9942cc4ac9aceef202f1c8 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -76,10 +76,15 @@ class ManagePasswordsUIController
const password_manager::PasswordStoreChangeList& changes) override;
// Called from the model when the user chooses to save a password; passes the
- // action off to the FormManager. The controller MUST be in a pending state,
- // and WILL be in MANAGE_STATE after this method executes.
+ // action to the FormManager. The controller MUST be in a pending state, and
vabr (Chromium) 2015/07/24 08:24:29 nit: "must" and "will". RFCs and other standards u
vabr (Chromium) 2015/07/24 08:24:29 nit: PasswordFormManager or "form manager". Just F
dvadym 2015/07/24 16:42:39 Done.
dvadym 2015/07/24 16:42:39 Done.
+ // WILL be in MANAGE_STATE after this method executes.
virtual void SavePassword();
+ // Called from the model when the user chooses to update a password; passes
+ // the action to the FormManager. The controller MUST be in a pending state,
+ // and WILL be in MANAGE_STATE after this method executes.
+ virtual void UpdatePassword(const autofill::PasswordForm& password_form);
+
// Called from the model when the user chooses a credential.
// The controller MUST be in a pending credentials state.
virtual void ChooseCredential(
@@ -151,6 +156,8 @@ class ManagePasswordsUIController
// The pieces of saving and blacklisting passwords that interact with
// FormManager, split off into internal functions for testing/mocking.
virtual void SavePasswordInternal();
+ virtual void UpdatePasswordInternal(
+ const autofill::PasswordForm& password_form);
virtual void NeverSavePasswordInternal();
// Called when a PasswordForm is autofilled, when a new PasswordForm is

Powered by Google App Engine
This is Rietveld 408576698