Update Confirmation UI for saved password change

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
@@ skipping 58 matching lines @@
   // stores a copy of |password_form_map| so that we can offer the user the
   // ability to reenable the manager for this form.
   void OnBlacklistBlockedAutofill(
       const autofill::PasswordFormMap& password_form_map);
 
   // PasswordStore::Observer implementation.
   void OnLoginsChanged(
       const password_manager::PasswordStoreChangeList& changes) override;
 
   // Called from the model when the user chooses to save a password; passes the
-  // action off to the FormManager. The controller MUST be in a pending state,
+  // action to the FormManager. The controller MUST be in a pending state, and

[vabr (Chromium), 2015/07/24 08:24:29]

nit: "must" and "will". RFCs and other standards use the upper-case to emphasise
that those terms have a specially defined meaning for the standards, but I don't
think there was any such definition for the comments here.

[vabr (Chromium), 2015/07/24 08:24:29]

nit: PasswordFormManager or "form manager". Just FormManager looks like a class
name, but there is no such class.

[dvadym, 2015/07/24 16:42:39]

Done.

[dvadym, 2015/07/24 16:42:39]

Done.

+  // WILL be in MANAGE_STATE after this method executes.
+  virtual void SavePassword();
+
+  // Called from the model when the user chooses to update a password; passes
+  // the action to the FormManager. The controller MUST be in a pending state,
   // and WILL be in MANAGE_STATE after this method executes.
-  virtual void SavePassword();
+  virtual void UpdatePassword(const autofill::PasswordForm& password_form);
 
   // Called from the model when the user chooses a credential.
   // The controller MUST be in a pending credentials state.
   virtual void ChooseCredential(
       const autofill::PasswordForm& form,
       password_manager::CredentialType credential_type);
 
   // Called from the model when the user chooses to never save passwords; passes
   // the action off to the FormManager. The controller MUST be in a pending
   // state, and WILL be in BLACKLIST_STATE after this method executes.
@@ skipping 52 matching lines @@
     return passwords_data_.federated_credentials_forms();
   }
 
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
+  virtual void UpdatePasswordInternal(
+      const autofill::PasswordForm& password_form);
   virtual void NeverSavePasswordInternal();
 
   // Called when a PasswordForm is autofilled, when a new PasswordForm is
   // submitted, or when a navigation occurs to update the visibility of the
   // manage passwords icon and bubble.
   virtual void UpdateBubbleAndIconVisibility();
 
   // Returns the time elapsed since |timer_| was initialized,
   // or base::TimeDelta::Max() if |timer_| was not initialized.
   virtual base::TimeDelta Elapsed() const;
@@ skipping 31 matching lines @@
   scoped_ptr<base::ElapsedTimer> timer_;
 
   // Contains true if the bubble is to be popped up in the next call to
   // UpdateBubbleAndIconVisibility().
   bool should_pop_up_bubble_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_