Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1151373003: Make roll_dep.py work on Windows (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Make roll_dep.py work on Windows Didn't have any shell=True for git.bat/cmd. Was able to upload https://codereview.chromium.org/1151373003 after this CL (though the printed description didn't make it to Rietveld, not sure if it normally does that.) R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295397

Patch Set 1 #

Total comments: 4

Patch Set 2 : setdefault #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M roll_dep.py View 1 6 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 7 months ago (2015-05-22 20:14:04 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/1151373003/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/1151373003/diff/1/roll_dep.py#newcode23 roll_dep.py:23: if 'shell' not in kwargs: kwargs.setdefault('shell', NEED_SHELL) https://codereview.chromium.org/1151373003/diff/1/roll_dep.py#newcode30 ...
5 years, 7 months ago (2015-05-22 20:16:13 UTC) #2
scottmg
https://codereview.chromium.org/1151373003/diff/1/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/1151373003/diff/1/roll_dep.py#newcode23 roll_dep.py:23: if 'shell' not in kwargs: On 2015/05/22 20:16:13, M-A ...
5 years, 7 months ago (2015-05-23 00:41:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373003/20001
5 years, 7 months ago (2015-05-23 00:41:44 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 00:44:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295397

Powered by Google App Engine
This is Rietveld 408576698