CL to add setFullscreen and setVsync to SkWindow

CL to add setFullscreen and setVsync to SkWindow

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/da7b843fbd263e3421eef27c833206024dae8528

[joshualitt, 2015-05-26 20:39:48]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, reed@google.com,
robertphillips@google.com

[joshualitt, 2015-05-26 20:39:49]

This CL is mostly to add setFullscreen and setVsync to SkWindow for linux.  I
added the VisualBench skeleton just to test this code, but its mostly just the
hello world program in fullscreen at this point.

[robertphillips, 2015-05-26 21:07:28]

https://codereview.chromium.org/1151333004/diff/80001/gyp/visualbench.gyp
File gyp/visualbench.gyp (right):

https://codereview.chromium.org/1151333004/diff/80001/gyp/visualbench.gyp#new...
gyp/visualbench.gyp:4: # found in the LICENSE file.
build "visual bench tool" ?

https://codereview.chromium.org/1151333004/diff/80001/src/views/unix/SkOSWind...
File src/views/unix/SkOSWindow_Unix.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/src/views/unix/SkOSWind...
src/views/unix/SkOSWindow_Unix.cpp:479: if (fUnixWindow.fDisplay &&
fUnixWindow.fGLContext && fUnixWindow.fWin) {
int swapInterval = vsync ? 1 : 0;

?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h
File tools/VisualBench.h (right):

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h#new...
tools/VisualBench.h:8: 
VisualBench_DEFINED ?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h#new...
tools/VisualBench.h:28: VisualBench(void* hwnd, int argc, char** argv);
rm virtual

[robertphillips, 2015-05-26 21:21:42]

https://codereview.chromium.org/1151333004/diff/80001/src/views/mac/SkOSWindo...
File src/views/mac/SkOSWindow_Mac.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/src/views/mac/SkOSWindo...
src/views/mac/SkOSWindow_Mac.cpp:541: 
Isn't this already in SkWindow.h ?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp
File tools/VisualBench.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp#n...
tools/VisualBench.cpp:15: #include "SkForceLinking.h"
Do we need GradientShader.h ?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp#n...
tools/VisualBench.cpp:26: 
static on this guy?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp#n...
tools/VisualBench.cpp:31: 
this guy too ?

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp#n...
tools/VisualBench.cpp:143: 
static ?

[joshualitt, 2015-05-27 14:09:34]

feedback inc

https://codereview.chromium.org/1151333004/diff/80001/gyp/visualbench.gyp
File gyp/visualbench.gyp (right):

https://codereview.chromium.org/1151333004/diff/80001/gyp/visualbench.gyp#new...
gyp/visualbench.gyp:4: # found in the LICENSE file.
On 2015/05/26 21:07:27, robertphillips wrote:
> build "visual bench tool" ?

Acknowledged.

https://codereview.chromium.org/1151333004/diff/80001/src/views/mac/SkOSWindo...
File src/views/mac/SkOSWindow_Mac.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/src/views/mac/SkOSWindo...
src/views/mac/SkOSWindow_Mac.cpp:541: 
On 2015/05/26 21:21:41, robertphillips wrote:
> Isn't this already in SkWindow.h ?

Yes, but I'm going to go through and fill these out later so may as well leave
them in.

https://codereview.chromium.org/1151333004/diff/80001/src/views/unix/SkOSWind...
File src/views/unix/SkOSWindow_Unix.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/src/views/unix/SkOSWind...
src/views/unix/SkOSWindow_Unix.cpp:479: if (fUnixWindow.fDisplay &&
fUnixWindow.fGLContext && fUnixWindow.fWin) {
On 2015/05/26 21:07:27, robertphillips wrote:
> int swapInterval = vsync ? 1 : 0;
> 
> ?

Acknowledged.

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp
File tools/VisualBench.cpp (right):

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.cpp#n...
tools/VisualBench.cpp:143: 
On 2015/05/26 21:21:41, robertphillips wrote:
> static ?

this is actually called from another file

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h
File tools/VisualBench.h (right):

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h#new...
tools/VisualBench.h:8: 
On 2015/05/26 21:07:27, robertphillips wrote:
> VisualBench_DEFINED ?

Acknowledged.

https://codereview.chromium.org/1151333004/diff/80001/tools/VisualBench.h#new...
tools/VisualBench.h:28: VisualBench(void* hwnd, int argc, char** argv);
On 2015/05/26 21:07:27, robertphillips wrote:
> rm virtual

Acknowledged.

[bsalomon, 2015-05-27 14:32:25]

lgtm

https://codereview.chromium.org/1151333004/diff/100001/src/views/unix/SkOSWin...
File src/views/unix/SkOSWindow_Unix.cpp (right):

https://codereview.chromium.org/1151333004/diff/100001/src/views/unix/SkOSWin...
src/views/unix/SkOSWindow_Unix.cpp:455: _NET_WM_STATE_REMOVE =0,
tab these out?

https://codereview.chromium.org/1151333004/diff/100001/tools/VisualBench.cpp
File tools/VisualBench.cpp (right):

https://codereview.chromium.org/1151333004/diff/100001/tools/VisualBench.cpp#...
tools/VisualBench.cpp:109: this->setUpRenderTarget();
setup?

[joshualitt, 2015-05-27 15:54:32]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-27 15:54:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1151333004/#ps140002
(title: "more")

[commit-bot: I haz the power, 2015-05-27 15:54:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151333004/140002

[commit-bot: I haz the power, 2015-05-27 15:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-27 15:57:53]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[joshualitt, 2015-05-27 16:13:33]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-27 16:13:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1151333004/#ps190001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-27 16:13:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151333004/190001

[commit-bot: I haz the power, 2015-05-27 16:19:06]

Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/da7b843fbd263e3421eef27c833206024dae8528