Fix positioning of autofill popup on rtl

chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h"
 
 #include <math.h>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/string_split.h"
@@ skipping 65 matching lines @@
     password_manager::PasswordManagerDriver* driver,
     PasswordGenerationPopupObserver* observer,
     content::WebContents* web_contents,
     gfx::NativeView container_view)
     : view_(NULL),
       form_(form),
       password_manager_(password_manager),
       driver_(driver),
       observer_(observer),
       generator_(new PasswordGenerator(max_length)),
-      controller_common_(bounds, container_view, web_contents),
+      // TODO(estade): use correct text direction.

[Garrett Casto, 2015/05/26 04:30:14]

Shouldn't this just be

base::i18n::GetTextDirectionForLocale(icu::Locale::getDefault().getName());

I'm not sure why this isn't part of the base::i18n API directly. It might be
slightly cleaner to have ControllerCommon take a boolean for is_rtl instead of
the actual text direction. Then you could just use base::i18n::isRTL(). Either
way seems fine to me.

[Evan Stade, 2015/05/26 18:30:47]

I suspect (but am not certain) you want to do the same thing Autofill does,
which is match the text direction of the triggering input, not the Chrome
locale.

+      controller_common_(bounds,
+                         base::i18n::LEFT_TO_RIGHT,
+                         container_view,
+                         web_contents),
       password_selected_(false),
       display_password_(false),
       weak_ptr_factory_(this) {
   controller_common_.SetKeyPressCallback(
       base::Bind(&PasswordGenerationPopupControllerImpl::HandleKeyPressEvent,
                  base::Unretained(this)));
 
   int link_id = IDS_MANAGE_PASSWORDS_LINK;
   int help_text_id = IDS_PASSWORD_GENERATION_PROMPT;
   const ProfileSyncService* sync_service =
@@ skipping 192 matching lines @@
 
 const base::string16& PasswordGenerationPopupControllerImpl::HelpText() {
   return help_text_;
 }
 
 const gfx::Range& PasswordGenerationPopupControllerImpl::HelpTextLinkRange() {
   return link_range_;
 }
 
 }  // namespace autofill