Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1151153004: Can't open <select> popup with an <option> text including "</script>". (Closed)

Created:
5 years, 7 months ago by tkent
Modified:
5 years, 7 months ago
Reviewers:
keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Can't open <select> popup with an <option> text including "</script>". We should escape "</script>" when we generate an internal HTML document. BUG=490607 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/PagePopupClient.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
A Source/core/page/PagePopupClientTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 7 months ago (2015-05-22 05:42:47 UTC) #2
keishi
lgtm
5 years, 7 months ago (2015-05-22 11:41:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151153004/1
5 years, 7 months ago (2015-05-22 12:04:06 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 12:07:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195781

Powered by Google App Engine
This is Rietveld 408576698