Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1151143002: Revert of Pass GC flags to incremental marker and start incremental marking with (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) Reason for revert: [Sheriff] Speculative revert because chromebook is really misbehaving: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. Original issue's description: > Pass GC flags to incremental marker and start incremental marking with > reduce memory footprint in idle notification. > > BUG= > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > Cr-Commit-Position: refs/heads/master@{#28567} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 Cr-Commit-Position: refs/heads/master@{#28568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M src/heap/heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Pass GC flags to incremental marker and start incremental marking with
5 years, 7 months ago (2015-05-21 20:34:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151143002/1
5 years, 7 months ago (2015-05-21 20:34:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 20:34:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 Cr-Commit-Position: refs/heads/master@{#28568}
5 years, 7 months ago (2015-05-21 20:35:00 UTC) #4
Michael Achenbach
5 years, 7 months ago (2015-05-22 05:51:53 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1157613002/ by machenbach@chromium.org.

The reason for reverting is: Wasn't the reason....

Powered by Google App Engine
This is Rietveld 408576698