Added an ActivationReason parameter to ActivationChangeObserver::OnWindowActivated(...).

Added an ActivationReason parameter to ActivationChangeObserver::OnWindowActivated(...).

TEST=FocusControllerApiTest.DuplicateActivationEvents
TEST=FocusControllerApiTest.ActivationEvents
TEST=FocusControllerMouseEventTest.DuplicateActivationEvents
TEST=FocusControllerMouseEventTest.ActivationEvents
TEST=FocusControllerGestureEventTest.DuplicateActivationEvents
TEST=FocusControllerGestureEventTest.ActivationEvents
TEST=FocusControllerHideTest.ActivationEvents
TEST=FocusControllerDestructionTest.ActivationEvents
TEST=FocusControllerRemovalTest.ActivationEvents

BUG=489813, 489814
Committed: https://crrev.com/5681d88c96e685a4e469105e8fcb382dc9893c9a
Cr-Commit-Position: refs/heads/master@{#333048}

[bruthig, 2015-06-04 17:42:36]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2015-06-04 17:42:37]

*** NOTE: This CL is based off of https://codereview.chromium.org/1157843009/.

sky@, can you please have a look?

[sky, 2015-06-04 20:02:04]

LGTM

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
File ui/wm/core/default_activation_client.cc (right):

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
ui/wm/core/default_activation_client.cc:100: NULL, window);
nullptr

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
ui/wm/core/default_activation_client.cc:139: next_active, NULL);
nullptr

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/focus_controller.cc
File ui/wm/core/focus_controller.cc (right):

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/focus_controller...
ui/wm/core/focus_controller.cc:111: void
FocusController::FocusAndActivateWindow(
Move implementation to match position in header.

[bruthig, 2015-06-04 21:07:41]

Addressed sky@'s nits from patch set 1.

No need to review.

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
File ui/wm/core/default_activation_client.cc (right):

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
ui/wm/core/default_activation_client.cc:100: NULL, window);
On 2015/06/04 20:02:03, sky wrote:
> nullptr

Done.

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/default_activati...
ui/wm/core/default_activation_client.cc:139: next_active, NULL);
On 2015/06/04 20:02:03, sky wrote:
> nullptr

Done.

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/focus_controller.cc
File ui/wm/core/focus_controller.cc (right):

https://codereview.chromium.org/1151133003/diff/1/ui/wm/core/focus_controller...
ui/wm/core/focus_controller.cc:111: void
FocusController::FocusAndActivateWindow(
On 2015/06/04 20:02:04, sky wrote:
> Move implementation to match position in header.

Done.

[bruthig, 2015-06-04 21:07:47]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-06-04 21:07:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1151133003/#ps40001
(title: "Uploaded diff based on dependant CL.")

[commit-bot: I haz the power, 2015-06-04 21:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151133003/40001

[commit-bot: I haz the power, 2015-06-04 21:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 21:27:50]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[bruthig, 2015-06-05 15:25:45]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2015-06-05 15:26:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151133003/40001

[commit-bot: I haz the power, 2015-06-05 15:33:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 15:34:32]

Patchset 3 (id:??) landed as
https://crrev.com/5681d88c96e685a4e469105e8fcb382dc9893c9a
Cr-Commit-Position: refs/heads/master@{#333048}