src/objects-debug.cc - Issue 1150953002: Generalize HeapObject alignment requirements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 1150953002: Generalize HeapObject alignment requirements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index a4c58244ef417818a754bd998ac4919c7b6ce74e..98b0aa5e65ae184ed11fd2701b2b4a21f9df7a04 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -48,7 +48,7 @@ void HeapObject::HeapObjectVerify() {

}

// TODO(yangguo): Use this check once crbug/436911 has been fixed.

Hannes Payer (out of office) 2015/05/21 09:53:31 That should be fixed now, we can remove the uncomm

bbudge 2015/05/21 10:02:07 Great, Done.

- // DCHECK(!NeedsToEnsureDoubleAlignment() ||

+ // DCHECK(RequiredAlignment() != kDoubleAlignment ||

// IsAligned(OffsetFrom(address()), kDoubleAlignment));

switch (instance_type) {

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/snapshot/serialize.cc » ('J')