Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/objects-debug.cc

Issue 1150953002: Generalize HeapObject alignment requirements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/disasm.h" 7 #include "src/disasm.h"
8 #include "src/disassembler.h" 8 #include "src/disassembler.h"
9 #include "src/heap/objects-visiting.h" 9 #include "src/heap/objects-visiting.h"
10 #include "src/jsregexp.h" 10 #include "src/jsregexp.h"
(...skipping 29 matching lines...) Expand all
40 40
41 41
42 void HeapObject::HeapObjectVerify() { 42 void HeapObject::HeapObjectVerify() {
43 InstanceType instance_type = map()->instance_type(); 43 InstanceType instance_type = map()->instance_type();
44 44
45 if (instance_type < FIRST_NONSTRING_TYPE) { 45 if (instance_type < FIRST_NONSTRING_TYPE) {
46 String::cast(this)->StringVerify(); 46 String::cast(this)->StringVerify();
47 return; 47 return;
48 } 48 }
49 49
50 // TODO(yangguo): Use this check once crbug/436911 has been fixed. 50 // TODO(yangguo): Use this check once crbug/436911 has been fixed.
Hannes Payer (out of office) 2015/05/21 09:53:31 That should be fixed now, we can remove the uncomm
bbudge 2015/05/21 10:02:07 Great, Done.
51 // DCHECK(!NeedsToEnsureDoubleAlignment() || 51 // DCHECK(RequiredAlignment() != kDoubleAlignment ||
52 // IsAligned(OffsetFrom(address()), kDoubleAlignment)); 52 // IsAligned(OffsetFrom(address()), kDoubleAlignment));
53 53
54 switch (instance_type) { 54 switch (instance_type) {
55 case SYMBOL_TYPE: 55 case SYMBOL_TYPE:
56 Symbol::cast(this)->SymbolVerify(); 56 Symbol::cast(this)->SymbolVerify();
57 break; 57 break;
58 case MAP_TYPE: 58 case MAP_TYPE:
59 Map::cast(this)->MapVerify(); 59 Map::cast(this)->MapVerify();
60 break; 60 break;
61 case HEAP_NUMBER_TYPE: 61 case HEAP_NUMBER_TYPE:
(...skipping 1218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 ? it.rinfo()->target_cell() 1280 ? it.rinfo()->target_cell()
1281 : it.rinfo()->target_object(); 1281 : it.rinfo()->target_object();
1282 CHECK(!CanLeak(target, heap, skip_weak_cell)); 1282 CHECK(!CanLeak(target, heap, skip_weak_cell));
1283 } 1283 }
1284 } 1284 }
1285 1285
1286 1286
1287 #endif // DEBUG 1287 #endif // DEBUG
1288 1288
1289 } } // namespace v8::internal 1289 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/snapshot/serialize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698