extensions/renderer/script_injection.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix extension page content scripts Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/extension_injection_host.h ('K') | « extensions/renderer/programmatic_script_injector.cc ('k') | extensions/renderer/script_injection_manager.cc » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_injection.cc

diff --git a/extensions/renderer/script_injection.cc b/extensions/renderer/script_injection.cc

index 5ab2ea55535690d53e86052f79acee44420427fa..1c342c4346a285e9a57e4eabce19580482ced3c8 100644

--- a/extensions/renderer/script_injection.cc

+++ b/extensions/renderer/script_injection.cc

@@ -136,8 +136,7 @@ ScriptInjection::InjectionResult ScriptInjection::TryToInject(

}

switch (injector_->CanExecuteOnFrame(

- injection_host_.get(), web_frame_, tab_id_,

- web_frame_->top()->document().url())) {

+ injection_host_.get(), web_frame_, tab_id_)) {

case PermissionsData::ACCESS_DENIED:

NotifyWillNotInject(ScriptInjector::NOT_ALLOWED);

return INJECTION_FINISHED; // We're done.