extensions/renderer/extension_injection_host.h - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_injection_host.h

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix extension page content scripts Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_messages.h ('K') | « extensions/renderer/extension_frame_helper.cc ('k') | extensions/renderer/extension_injection_host.cc » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/extension_injection_host.h

diff --git a/extensions/renderer/extension_injection_host.h b/extensions/renderer/extension_injection_host.h

index 1b77cacfb206c8781383757aaab346f03b491d56..252d0da226a013367b35c78c3ac808a74e897650 100644

--- a/extensions/renderer/extension_injection_host.h

+++ b/extensions/renderer/extension_injection_host.h

@@ -33,7 +33,7 @@ class ExtensionInjectionHost : public InjectionHost {

const std::string& name() const override;

PermissionsData::AccessType CanExecuteOnFrame(

const GURL& document_url,

- const GURL& top_frame_url,

+ blink::WebFrame* web_frame,

not at google - send to devlin 2015/06/03 20:15:45 Perhaps begin the trend of preferring RenderFrame

Devlin 2015/06/03 20:28:47 Sure, done.

int tab_id,

bool is_declarative) const override;

bool ShouldNotifyBrowserOfInjection() const override;